Added support for main plots #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Latest commit includes the skeleton code using the old GI Mapping results to build the volcano and GI rank plots |
|
Still need to add documentation for these functions as well as examples using them in the vignette Note that the bar plot isn't using the correct data, but this plot was not a necessary, just a preferred plot. @cansavvy slacked you about it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plot is recapitulating a main plot that was requested to be added to the package (Fig 3a/Sup 5k), but with the original results from GI_Mapping rather than the gimap results (since I couldn't find the exact code used to make those figures and wanted to make sure I understand how they were originally made.)
End goal is to rewrite this so that it can be produced from gimap results. In the mean time, would like feedback on whether it's handling the +- 2 residual dashed lines correctly.