-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dataspec html to visc_git_ignore #255
Conversation
hi @yungwenliu and @lemireg, we're thinking of adding .html file types onto the list of files to ignore in the use_visc_gitignore() function. Would this conflict with SRA analysis repo workflow (i.e., are SRAs currently versioning html files in git?) |
Per the conversation with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #255 +/- ##
===========================================
+ Coverage 82.05% 82.10% +0.05%
===========================================
Files 8 8
Lines 351 352 +1
===========================================
+ Hits 288 289 +1
Misses 63 63 ☔ View full report in Codecov by Sentry. |
@valduran18 it's not letting me add you as a reviewer, maybe since it's your PR, but can you thumbs up if this looks OK to you? We discussed this change on Slack, and SRAs indicated they were ok with it at yesterday's VISCtemplates mtg. |
Closes #254. Adding dataspec html to the list of files that VISC ignores in .gitignore
Checklist
devtools::document