Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dataspec html to visc_git_ignore #255

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Conversation

valduran18
Copy link
Contributor

@valduran18 valduran18 commented Dec 10, 2024

Closes #254. Adding dataspec html to the list of files that VISC ignores in .gitignore

Checklist

  • This PR includes unit tests
  • This PR establishes a new function or updates parameters in an existing function
    • The roxygen skeleton for this function has been updated using devtools::document
  • I have updated NEWS.md to describe the proposed changes

@valduran18
Copy link
Contributor Author

hi @yungwenliu and @lemireg, we're thinking of adding .html file types onto the list of files to ignore in the use_visc_gitignore() function. Would this conflict with SRA analysis repo workflow (i.e., are SRAs currently versioning html files in git?)

@kelliemac kelliemac requested a review from lemireg January 7, 2025 18:20
@lemireg
Copy link

lemireg commented Jan 7, 2025

hi @yungwenliu and @lemireg, we're thinking of adding .html file types onto the list of files to ignore in the use_visc_gitignore() function. Would this conflict with SRA analysis repo workflow (i.e., are SRAs currently versioning html files in git?)

Per the conversation with the VISCtemplates working group on 1/7/2025: we discussed SRA use of html files and agreed that the SRA workflow would not be affected by adding html files to the gitignore file. SRAs can manually remove this line from the gitignore file if their repo uses a lot of html files or they can force git add the file. Please go ahead with this change @valduran18

@lemireg lemireg marked this pull request as ready for review January 7, 2025 18:24
Copy link

@lemireg lemireg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@slager slager changed the base branch from main to develop January 8, 2025 19:35
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.10%. Comparing base (8aacbf7) to head (1ee0b7d).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #255      +/-   ##
===========================================
+ Coverage    82.05%   82.10%   +0.05%     
===========================================
  Files            8        8              
  Lines          351      352       +1     
===========================================
+ Hits           288      289       +1     
  Misses          63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slager
Copy link
Contributor

slager commented Jan 8, 2025

@valduran18 it's not letting me add you as a reviewer, maybe since it's your PR, but can you thumbs up if this looks OK to you? We discussed this change on Slack, and SRAs indicated they were ok with it at yesterday's VISCtemplates mtg.

@slager slager merged commit b8969f4 into develop Jan 8, 2025
6 checks passed
@slager slager deleted the visc_git_ignore_dataspec_html branch January 8, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add dataspec html to use_visc_gitignore
3 participants