Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict symbol resolving to language #1857

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Nov 20, 2024

Currently, the symbol resolver runs wild and considers all nodes of all languages. When we have more instances where we have multiple languages in the same component, this craates a problem.

This PR now only considers the same language as the ref we are looking for.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 91.07143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.34%. Comparing base (897955d) to head (89176e8).

Files with missing lines Patch % Lines
...ain/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt 90.00% 0 Missing and 2 partials ⚠️
...tlin/de/fraunhofer/aisec/cpg/passes/GoExtraPass.kt 50.00% 0 Missing and 2 partials ⚠️
...tlin/de/fraunhofer/aisec/cpg/graph/scopes/Scope.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...main/kotlin/de/fraunhofer/aisec/cpg/TypeManager.kt 82.85% <100.00%> (ø)
...n/de/fraunhofer/aisec/cpg/passes/ImportResolver.kt 90.10% <100.00%> (+0.57%) ⬆️
...n/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt 88.40% <100.00%> (+0.18%) ⬆️
...lin/de/fraunhofer/aisec/cpg/passes/TypeResolver.kt 95.65% <100.00%> (+0.09%) ⬆️
...r/aisec/cpg/frontends/golang/DeclarationHandler.kt 91.01% <100.00%> (ø)
...fer/aisec/cpg/frontends/llvm/DeclarationHandler.kt 86.59% <100.00%> (ø)
...ofer/aisec/cpg/frontends/llvm/ExpressionHandler.kt 74.37% <100.00%> (ø)
...aisec/cpg/frontends/llvm/LLVMIRLanguageFrontend.kt 87.37% <100.00%> (ø)
...ofer/aisec/cpg/passes/PythonAddDeclarationsPass.kt 90.47% <100.00%> (ø)
...tlin/de/fraunhofer/aisec/cpg/graph/scopes/Scope.kt 81.94% <80.00%> (-1.39%) ⬇️
... and 2 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxisto oxisto marked this pull request as ready for review November 20, 2024 17:44
oxisto and others added 9 commits November 30, 2024 23:11
Currently, the symbol resolver runs wild and considers all nodes of all languages. When we have more instances where we have multiple languages in the same component, this craates a problem.

This PR now only considers the same language as the ref we are looking for.
@oxisto
Copy link
Member Author

oxisto commented Nov 30, 2024

Looking for review ;) @maximiliankaul @KuechA @konradweiss @lshala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant