Clean up #763
Merged
Clean up #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pgBackend class and rename to BaseCpgBackenCommand for consistency
paramInstance is the script instance so it should probably never be an argument for the primaryConstructor. Furthermore, we check above that the primaryConstructor does not have any parameters, so it should not be necessary to use the script instance as a argument.
This reverts commit f2ad444. In some cases the script instance is needed as an argument for some constructors
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #763 +/- ##
============================================
+ Coverage 82.14% 82.39% +0.24%
Complexity 179 179
============================================
Files 49 49
Lines 1372 1363 -9
Branches 189 184 -5
============================================
- Hits 1127 1123 -4
Misses 157 157
+ Partials 88 83 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Some of the changes have been addresses in other PRs. We'll first merge: Afterwards, we'll take another look at code coverage. |
CodingDepot
previously approved these changes
Apr 10, 2024
CodingDepot
approved these changes
Apr 10, 2024
fwendland
approved these changes
Apr 10, 2024
fwendland
added a commit
that referenced
this pull request
Apr 15, 2024
Co-authored-by: Florian Wendland <[email protected]> Co-authored-by: Robert Haimerl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the code a little bit