Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: next image issue #790

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Fix: next image issue #790

merged 3 commits into from
Nov 5, 2023

Conversation

ololade2002
Copy link
Contributor

@ololade2002 ololade2002 commented Nov 5, 2023

Resolves #789
I fixed the next image issue. It had to do with the height and width issue and i also ran into an issue with the husky pre commit msg

Summary by CodeRabbit

  • Chores
    • Improved commit message validation by enabling Husky commitlint.
  • Style
    • Adjusted image dimensions in the GetActivities component for better visual presentation.

Copy link

vercel bot commented Nov 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
4c-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2023 8:09am

Copy link

coderabbitai bot commented Nov 5, 2023

Walkthrough

The changes made are primarily focused on enhancing the commit message validation in the husky configuration and adjusting the dimensions of an image in a React component. The commit message validation is now handled by commitlint, and the image size has been set to 20 pixels.

Changes

File Summary
.husky/commit-msg Added shebang line, uncommented husky.sh line, and added commitlint command for commit message validation.
src/components/.../GetActivities.js Added width and height attributes to an img element, setting the image size to 20 pixels.

Poem

🐇 Hopping through the code, making changes bright,

In the cool November's coding night. 🌙

Commit messages now neat, and images just right,

Celebrating the joy of code's light. 💻✨

So here's to the devs, in their coding might,

Making the digital world a delightful sight. 🌍🎉


Validation against linked GitHub Issue (Beta)

Assessment

Objective Addressed Explanation
Fix the bug causing an error with the width and height of an image The code changes in src/components/GetActivities.js include the addition of width and height attributes to an img element, setting the width and height of the image to 20 pixels.
Ensure the website shows on the local server The changes in .husky/commit-msg suggest an attempt to enforce commit message standards, which could indirectly help with running the website locally. However, without more specific information about the original bug, it's unclear if this change directly addresses the issue of the website not showing on the local server.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, ololade2002! 🎉 Thank you for submitting your first pull request to 4C. Your contribution is valuable and we appreciate your efforts to improve our project. We'll review your changes and provide feedback as soon as possible. Keep up the great work!

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ea4d718 and 09d79b6.
Files ignored due to filter (1)
  • yarn.lock
Files selected for processing (2)
  • .husky/commit-msg (1 hunks)
  • src/components/GetActivities.js (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/components/GetActivities.js
Additional comments: 1
.husky/commit-msg (1)
  • 1-4: The changes in this file enable the husky pre-commit hook and add commitlint to check the commit messages. This is a good practice as it ensures that all commit messages follow a standard format, improving the readability and understanding of the project's history.

@tobySolutions tobySolutions merged commit 68da1c2 into FrancescoXX:main Nov 5, 2023
3 checks passed
@tobySolutions
Copy link
Collaborator

LGTM! Great job @ololade2002

Copy link
Contributor

github-actions bot commented Nov 5, 2023

🎉 This PR is included in version 0.21.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Next image width and height error
2 participants