Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Add linux udev instructions #25

Merged
merged 1 commit into from
Oct 25, 2023
Merged

README: Add linux udev instructions #25

merged 1 commit into from
Oct 25, 2023

Conversation

JohnAZoidberg
Copy link
Member

No description provided.

README.md Outdated
Pre-requisites:

- [Rust](https://rustup.rs/)
- libudev

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! You might want to mention that the libudev apt is usually available at libudev-dev or just say (most systems: sudo apt install libudev-dev.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about that. But then I was running fedora and it's called something else there...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it actually now ;)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, I like that you added instructions for our two most popular distros!

@zachfeldman zachfeldman self-requested a review October 24, 2023 13:19
Copy link

@zachfeldman zachfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates! The instructions work, just a few suggestions to make it slightly more clear for those reading it.

Pre-requisites:

- [Rust](https://rustup.rs/)
- libudev

```sh
cargo build

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This did indeed work! It might be better to tell folks how to run it after they build it. Instead of the ls -l, ./target/debug/qmk_hid.

zach@zach-lotus:~/dev/qmk_hid (main)$ cargo build
    Updating crates.io index
  Downloaded anstyle v1.0.1
  Downloaded anstyle-parse v0.2.1
  Downloaded once_cell v1.18.0
  Downloaded quote v1.0.29
  Downloaded clap_derive v4.3.2
  Downloaded anstream v0.3.2
  Downloaded clap v4.3.9
  Downloaded proc-macro2 v1.0.63
  Downloaded clap_builder v4.3.9
  Downloaded syn v2.0.22
  Downloaded hidapi v2.3.3
  Downloaded libc v0.2.147
  Downloaded 12 crates (1.7 MB) in 0.33s
   Compiling libc v0.2.147
   Compiling io-lifetimes v1.0.11
   Compiling rustix v0.37.20
   Compiling proc-macro2 v1.0.63
   Compiling bitflags v1.3.2
   Compiling unicode-ident v1.0.9
   Compiling quote v1.0.29
   Compiling linux-raw-sys v0.3.8
   Compiling pkg-config v0.3.27
   Compiling cc v1.0.79
   Compiling utf8parse v0.2.1
   Compiling anstyle v1.0.1
   Compiling anstyle-query v1.0.0
   Compiling colorchoice v1.0.0
   Compiling static_vcruntime v2.0.0
   Compiling clap_lex v0.5.0
   Compiling strsim v0.10.0
   Compiling anstyle-parse v0.2.1
   Compiling heck v0.4.1
   Compiling once_cell v1.18.0
   Compiling qmk_hid v0.1.11 (/home/zach/dev/qmk_hid)
   Compiling hidapi v2.3.3
   Compiling syn v2.0.22
   Compiling is-terminal v0.4.7
   Compiling anstream v0.3.2
   Compiling clap_builder v4.3.9
   Compiling clap_derive v4.3.2
   Compiling clap v4.3.9
    Finished dev [unoptimized + debuginfo] target(s) in 4.44s
zach@zach-lotus:~/dev/qmk_hid (main)$ ls -l target/debug/qmk_hid
-rwxrwxr-x 2 zach zach 20062248 Oct 24 09:17 target/debug/qmk_hid
zach@zach-lotus:~/dev/qmk_hid (main)$ ls target/debug/qmk_hid
target/debug/qmk_hid
zach@zach-lotus:~/dev/qmk_hid (main)$ ./target/debug/qmk_hid 
RAW HID and VIA commandline for QMK devices

Usage: qmk_hid [OPTIONS] [COMMAND]

Commands:
  factory  Factory
  via      Via
  qmk      QMK
  help     Print this message or the help of the given subcommand(s)

Options:
  -l, --list       List connected HID devices
  -v, --verbose    Verbose outputs to the console
      --vid <VID>  VID (Vendor ID) in hex digits
      --pid <PID>  PID (Product ID) in hex digits
  -h, --help       Print help
  -V, --version    Print version
zach@zach-lotus:~/dev/qmk_hid (main)$ ./target/debug/qmk_hid -l
32ac:0012
  Manufacturer: "Framework"
  Product:      "Laptop 16 Keyboard Module - ANSI"
  FW Version:   0.2.3
  Serial No:    "FRAKDKEN0100000000"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea, yeah

@JohnAZoidberg JohnAZoidberg merged commit 3679a23 into main Oct 25, 2023
4 checks passed
@JohnAZoidberg JohnAZoidberg deleted the readme branch October 25, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants