Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Utils): Add signature verification utility function #81

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat(Utils): Add signature verification utility function #81

wants to merge 3 commits into from

Conversation

jhodges10
Copy link
Contributor

@jhodges10 jhodges10 commented Jun 20, 2021 •
edited
Loading

DEVREL-558

What I'm doing

  • Adding signature verification util for custom actions/webhooks

Tests

  • Need to add test for this function

@jhodges10 jhodges10 changed the title Add signature verification util WIP Add signature verification util Jun 20, 2021
@jhodges10 jhodges10 added the enhancement New feature or request label Jun 20, 2021
@jhodges10 jhodges10 requested a review from lezoudali July 7, 2021 09:18
@jhodges10 jhodges10 force-pushed the jh/add-signature-verification-util branch from 4d883c6 to a74dbfd Compare July 30, 2021 04:18
@jhodges10 jhodges10 changed the title WIP Add signature verification util feat(Utils): Add signature verification utility function Aug 3, 2021
@jhodges10 jhodges10 mentioned this pull request Aug 3, 2021
Open
lezoudali
lezoudali approved these changes Dec 2, 2021
View reviewed changes
Copy link

@lezoudali lezoudali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. as long as you've tested and it works as expected. I'd add some tests? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lezoudali lezoudali lezoudali approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhodges10 @lezoudali