Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP chunk hashing on upload #80

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

jhodges10
Copy link
Contributor

@jhodges10 jhodges10 commented Jun 8, 2021

Description:
Introduces MD5 hashing of individual chunks during upload as part of the request headers, relying on AWS to confirm whether or not the bytes received match what know we're sending

If this works, it would mean that an upload that has a single corrupt bit in chunk 9,999/10,000 wouldn't require the entire file to be re-uploaded, just that specific chunk.

Current issues:

  • Apparently the chunk MD5 hash and the other headers are included as part of the signature for the pre-signed URL, ultimately I'm not sure if there's a way to get around this other than pre-calculate the MD5 hash for every chunk and including that as part of the asset create

AWS Documentation:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant