Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #99 where can't get API results with more than one page #101

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

seb26
Copy link

@seb26 seb26 commented Feb 19, 2024

Description:

Fix #99 which is when calling .get_children() and getting more than 50 results and therefore 2nd page and onwards, the frameioclient will send a request with bad URL encoded characters and containing no page number.

  File "/Users/seb/Development/frameio_dev/python-frameio-client/frameioclient/lib/utils.py", line 234, in __next__
    self.method, self.endpoint, self.payload, self.current_page
  File "/Users/seb/Development/frameio_dev/python-frameio-client/frameioclient/lib/transport.py", line 154, in get_specific_page
    return self._api_call(method, endpoint)
  File "/Users/seb/Development/frameio_dev/python-frameio-client/frameioclient/lib/transport.py", line 138, in _api_call
    return r.raise_for_status()
  File "/Users/seb/Development/frameio_dev/venv/lib/python3.7/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://api.frame.io/v2%7Bendpoint%7D?page=%7Bpage%7D

Depends on:

  • Does this PR depend on any other ones? no

Includes changes from:

  • Does this PR includ changes from another PR? no

I'd like feedback on:

  • What would you like feedback on?

@seb26 seb26 changed the title fix https://github.com/Frameio/python-frameio-client/issues/99 Fix #99 where can't get API results with more than one page Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String is not formatted
1 participant