Lint before build #2315
Open
Lint before build #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diokuz
force-pushed
the
lint-before-build
branch
from
19f0792 to
851219d
Compare
|
are you sure we need failing builds coz of linting/formatting errors? |
Diokuz
force-pushed
the
lint-before-build
branch
from
4cfc902 to
2d9896b
Compare
This reverts commit 99a80f5.
Diokuz
force-pushed
the
lint-before-build
branch
from
2d9896b to
4ed3ee7
Compare
Diokuz
force-pushed
the
lint-before-build
branch
from
a324859 to
7695fb8
Compare
Diokuz
force-pushed
the
lint-before-build
branch
8 times, most recently
from
9b85503 to
4ef4606
Compare
Diokuz
force-pushed
the
lint-before-build
branch
from
4ef4606 to
5a891f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done
checktask beforebuildfor fast pr fail if any linters fails.testtask now void, since we have not tests on top of built application.Result:
~5 m 20 s→~1 m 40 sto fail.