Move around some stuff in core._ #2313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(A couple of FIXMEs as a nice break from bugs :P)
michalrus
commented
Jun 27, 2017
| def ifElse[A](condition: Boolean, ifBranch: ⇒ DbResultT[A], elseBranch: ⇒ DbResultT[A]) = | ||
| if (condition) ifBranch else elseBranch | ||
|
|
||
| def doOrMeh(condition: Boolean, action: ⇒ DbResultT[_])(implicit ec: EC): DbResultT[Unit] = | ||
| if (condition) action.meh else DbResultT.unit | ||
| def when[F[_]](p: Boolean, s: ⇒ F[Unit])(implicit F: Applicative[F]): F[Unit] = |
There was a problem hiding this comment.
| @@ -276,15 +270,12 @@ package object db { | |||
| def appendForUpdate[A, B <: slick.dbio.NoStream](sql: SqlAction[A, B, Effect.Read]): DBIO[A] = | |||
| sql.overrideStatements(sql.statements.map(_ + " for update")) | |||
|
|
|||
| def lift[A](value: A): DBIO[A] = DBIO.successful(value) | |||
There was a problem hiding this comment.
Not needed, we have pure from cats.
| def apply[A](a: A)(implicit F: Monad[F]): FoxyT[F, A] = // TODO: remove me? @michalrus | ||
| pure(a) | ||
|
|
||
| def pure[A](a: A)(implicit F: Monad[F]): FoxyT[F, A] = |
There was a problem hiding this comment.
Not needed, we have pure from cats.
| @@ -105,20 +105,14 @@ package object db { | |||
| } | |||
|
|
|||
| trait FoxyTFunctions[F[_]] { | |||
| def apply[A](a: A)(implicit F: Monad[F]): FoxyT[F, A] = // TODO: remove me? @michalrus | |||
|
FMT! |
|
Yikes! |
michalrus
force-pushed
the
devexp/when-pure
branch
from
ddf83a5 to
a2bacc5
Compare
michalrus
force-pushed
the
devexp/when-pure
branch
from
a2bacc5 to
fd29f48
Compare
michalrus
commented
Jun 28, 2017
| @@ -18,7 +19,7 @@ object DiscountValidator { | |||
| def validate(fs: FormAndShadow)(implicit ec: EC): DbResultT[Unit] = | |||
| for { | |||
| failures ← * <~ IlluminateAlgorithm.validateAttributes(fs.form.attributes, fs.shadow.attributes) | |||
| _ ← * <~ failIfFailures(failures) | |||
| _ ← * <~ failIfFailures[DBIO](failures) // TODO: why no inference? @michalrus | |||
narma
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(A couple of FIXMEs as a nice break from bugs :P)