Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: pie chart animation #3006

Closed
wants to merge 2 commits into from
Closed

Conversation

djm158
Copy link
Contributor

@djm158 djm158 commented Dec 12, 2024

Description

This is just a draft explaining #2991

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

TODO

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: 1a8eafe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Dec 13, 2024 8:14pm

@@ -117,7 +117,7 @@ class VictoryPieBase extends React.Component<VictoryPieProps> {
duration: 500,
before: () => ({ _y: 0, label: " " }),
after: (datum) => ({
y_: datum._y,
_y: datum._y,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

originally thought this was the bug fix, but it is still present after this change

Partially resolves the issue of victory-pie animations not working as expected when nodes exit.
Issue persists when nodes enter again.
Copy link
Contributor

Folder/File Previous size New size Difference
/packages/victory/dist/victory.min.js 386.04KB 386.95KB +0.9KB (+0.23%)
TOTAL +0.9KB

@djm158 djm158 closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant