Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve types in victory-core helpers #2999

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Dec 6, 2024

Update types in victory-core helpers to improve refactoring and static type checking

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: 7150ba2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-axis Patch
victory-chart Patch
victory-core Patch
victory-cursor-container Patch
victory-group Patch
victory-legend Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-stack Patch
victory-tooltip Patch
victory-voronoi-container Patch
victory Patch
victory-area Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-canvas Patch
victory-create-container Patch
victory-errorbar Patch
victory-histogram Patch
victory-line Patch
victory-selection-container Patch
victory-shared-events Patch
victory-voronoi Patch
victory-zoom-container Patch
victory-native Patch
victory-vendor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Dec 6, 2024 4:38pm

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Folder/File Previous size New size Difference
/packages/victory/dist/victory.min.js 385.86KB 386.04KB +0.17KB (+0.05%)
TOTAL +0.17KB

@carbonrobot carbonrobot merged commit 618bd6d into main Dec 6, 2024
7 checks passed
@carbonrobot carbonrobot deleted the chore/improve-helpers-types branch December 6, 2024 18:32
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
carbonrobot added a commit that referenced this pull request Dec 9, 2024
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants