Multiple accounts for deployment #703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for several --account flags. The accounts passed must already have been logged in. `force import` uses a mutex to synchonize concurrent deployments.
easafe
force-pushed
the
deploy_71538615
branch
from
75cc0f4
to
d079636
Compare
cwarden
requested changes
Nov 23, 2024
| if _apiVersion != "" { | ||
| err := SetApiVersion(_apiVersion) | ||
| if err != nil { | ||
| ErrorAndExit(err.Error()) | ||
| } | ||
| } | ||
|
|
||
| force = manager.getCurrentForce() |
There was a problem hiding this comment.
We'll need to only allow multiple --account options for commands that have been updated to support it. It's confusing if we accept multiple accounts then don't use them.
There was a problem hiding this comment.
Which commands should support multiple accounts? Besides import
There was a problem hiding this comment.
I think we also need to make sure that accounts are unique
| deployments.Add(1) | ||
| go func() { | ||
| defer deployments.Done() | ||
| err := deployWith(current, &status, files, &options, displayOptions) |
There was a problem hiding this comment.
I think we'll need to return the results so we can combine them. We'll get invalid output, especially with --reporttype junit, if we let each goroutine write it its own results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for several --account flags. The accounts passed must already have been logged in.
force importuses a mutex to synchonize concurrent deployments.