Developer Definition of Done [ARCHIVED]

NOTE: This page has been archived. The information it is is presented in other locations. It will no longer be updated and can be assumed to be out of date.

When completing an assigned JIRA task or sub-task involving coding, the following checklist must all be complete in order to move the item to done in JIRA.

1. JIRA item moved to In Progress when started

2. Coded within feature branch

3. Code Quality: Make sure any new code meets project quality standards including:

   1. 4-space indents - convert any tabs to spaces
   2. Use public class field syntax for binding functions - ex. handleChange = () => { ... };

4. Tested: Make sure old tests pass, that new tests have been written, and that any warnings/errors that appear in your browser console are resolved. For information on how to write new tests and how to run old tests, see our testing page in our wiki.

5. Demonstration script updated and fully tested with changes in place

6. Documented (comments in code, separate documentation on approach/api if will be reused). N.B. Cheat sheets should be updated if a structured phrase is changed

7. Feature branch pushed to github and pull request issued and reviewers recommended or assigned.

8. Git pull request reviewed, all issues identified have been addressed, and pull request merged (after rebasing if master has changed) by a reviewer

9. Additional technical components/libraries pulled in are documented on wiki

10. Note parsing updated if structured phrases change. Note parsing should always be tested if shortcut classes changed at all

11. Make sure all date formatting and parsing is done using moment library instead of custom formatting functions. If you see any legacy cases of this in code you are editing, please replace them or add a JIRA to do it at least.

12. Make sure to manually test the application in IE and in Chrome