Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README and literature background to treebank #358

Merged

Conversation

lilianabs
Copy link
Contributor

Reference Issue 340.

Following some of the comments, this example contains fewer explanations and instead references the original paper that explains in detail how to model works.

@lilianabs lilianabs changed the title Add README and literature background Add README and literature background to treebank May 20, 2022
text/treebank/recursive.jl Outdated Show resolved Hide resolved
N::Int = 300
throttle::Int = 10 # Throttle timeout
throttle::Int = 10 ## Throttle timeout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these ## special literate syntax as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they're special literate syntax :)

Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If there's nothing else you'd like to add, this is ready to merge.

@CarloLucibello CarloLucibello merged commit b3e1891 into FluxML:master May 29, 2022
@mcabbott mcabbott added the documentation words & links, not code label Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation words & links, not code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants