-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add literature background to the models #340
Comments
This is great! Looking ahead to the website step, I think it would be better and simpler to just host a "model zoo" or "tutorials" section in the Flux docs themselves:
|
Thank you @darsnack! Totally agree with your comments. |
I think it is good to add some comments to some of the basics examples, but I wouldn't want them to be too loaded either. Model-zoo examples are supposedly used for bootstrapping user projects, they aren't meant as tutorials (which we lack and should live in Flux.jl). |
We can use Literate to create a "clean" version of the examples. |
Regarding the Simple ConvNet (LeNet5) example, I noticed it is using Any reason for these discrepancies? |
@cossio I just wrote the text and took the code as it was on the repo. Perhaps somebody else can comment on these discrepancies? |
I think that's a modernized version of Lenet5 (relu had not been "invented" at the time) which I've found somewhere (don't remember where though). Maybe we can add a comment on that saying that the original model uses sigmoids? |
Added a note to the model to specify this. |
I'll start working on adding literature background to all of the existing models (ref #312). Then, we can move on to working on creating a standalone site to host all of the models as notebooks.
I plan to cover the following models:
@DhairyaLGandhi @logankilpatrick just tagging you to keep you in the loop :)
The text was updated successfully, but these errors were encountered: