-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate dropgrad
and ignore
#1245
Conversation
Perhaps we could add a note in the docs about these deprecations pointing to CRC, or keep the autodocs and add pointers in the docstrings? |
The integration test failures could be real |
NeuralPDE failure is strictly on downstream and not us, kicking the tires again to see if DynamicPPL fixes itself per #1114 (comment). |
Good idea, I've added a note to the docs.
NeuralPDE.jl seems to be failing with the same error as master. DynamicPPL fails locally for me (but CI runs). Maybe @devmotion could advise whether there are any special requirements on running tests locally? |
No, there shouldn't. I assume locally you don't run them with the latest release of DistributionsAD, most likely because you pinned or checked out some packages or (possibly unintentially) created a Manifest.toml file. |
DynamicPPL seems to have been fixed. Good to go? I don't have merge rights so please just merge when ready. |
Done, thanks! |
Contributes to #1235
I'll do
nograd
separately since it is used for a few adjoints that may need to be ported first.