Add a specialization for Cholesky adjoint on the GPU #1238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
reviewed
Jun 9, 2022
| @@ -593,6 +593,23 @@ end | |||
| end | |||
| end | |||
|
|
|||
| @init @require CUDA="052768ef-5323-5732-b1bb-66c8b64840ba" begin | |||
| Zygote.@adjoint function cholesky(Σ::Union{CUDA.CuMatrix, Symmetric{<:Real, <:CUDA.CuMatrix}}; check = true) | |||
There was a problem hiding this comment.
Do you mind changing this to use rrule(::ZygoteRuleConfig, ...) instead of @adjoint? #923 has some examples, and I'd be happy to help too.
There was a problem hiding this comment.
Sure, I'll do it once the ChainRules.jl business is sorted out below.
|
News: Before merging this PR, some additional commits might be needed soon. See this issue. |
|
It seems this can be closed in favour of #1114 now that the GPU issues and problems with that PR were fixed in CR 1.35.3. |
|
Indeed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #1210