Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 2 items from public, to fix 1.12 #2569

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Remove 2 items from public, to fix 1.12 #2569

merged 1 commit into from
Dec 31, 2024

Conversation

mcabbott
Copy link
Member

@mcabbott mcabbott commented Dec 31, 2024

On master, but not on 1.11, Flux cannot be loaded because some symbols are both public and exported:

julia> using Flux
Info Given Flux was explicitly requested, output will be shown live 
ERROR: LoadError: cannot declare Flux.trainables public; it is already declared exported

julia> VERSION
v"1.12.0-DEV.1731"

Tracking things down, this was changed in JuliaLang/julia#53664 . It means that @reexport using Optimisers is fragile -- if Optimisers.jl exports a symbol marked public here, it will immediately break Flux.

(Was not noticed here for ages, Zygote wasn't compiling on master until FluxML/Zygote.jl#1542)

Does not fix CI on master, which really should just not try to load Enzyme at all:

Failed to precompile Enzyme [7da242da-08ed-463a-9acd-ee780be4f1d9] to "/home/runner/.julia/compiled/v1.12/Enzyme/jl_FMXEUb".
ERROR: LoadError: UndefVarError: verbose_stmt_info not defined in Compiler

@mcabbott mcabbott mentioned this pull request Dec 31, 2024
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.50%. Comparing base (13bb061) to head (9af30ea).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2569   +/-   ##
=======================================
  Coverage   32.50%   32.50%           
=======================================
  Files          34       34           
  Lines        2003     2003           
=======================================
  Hits          651      651           
  Misses       1352     1352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcabbott mcabbott merged commit b205266 into master Dec 31, 2024
7 of 12 checks passed
@mcabbott mcabbott deleted the mcabbott-patch-2 branch December 31, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants