Remove 2 items from public, to fix 1.12 #2569
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master, but not on 1.11, Flux cannot be loaded because some symbols are both public and exported:
Tracking things down, this was changed in JuliaLang/julia#53664 . It means that
@reexport using Optimisers
is fragile -- if Optimisers.jl exports a symbol marked public here, it will immediately break Flux.(Was not noticed here for ages, Zygote wasn't compiling on master until FluxML/Zygote.jl#1542)
Does not fix CI on master, which really should just not try to load Enzyme at all: