Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include image dimensions in generated AssetGenImage class #431

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Include image dimensions in generated AssetGenImage class #431

merged 7 commits into from
Jan 30, 2024

Commits on Jan 12, 2024

  1. Refactored AssetType to be passed to Integration.classInstantiate ins… 

    …tead of a string path.

This enables the Integration to be smarter with what they do with the asset. This also included refactoring how and where posixPath is used. This potentially leads to less error prone usage.
    @bramp
    bramp committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    4d5585d View commit details
    Browse the repository at this point in the history

  2. Add new parse_metadata config flag, to (if possible) parse and includ… 

    …e additional asset information in the generated file.
    @bramp
    bramp committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    dd1c950 View commit details
    Browse the repository at this point in the history

  3. Changed the SvgIntegration to parse metadata, and include the image's… 

    … width/height in the generated assets.gen.dart.
    @bramp
    bramp committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    e7e515c View commit details
    Browse the repository at this point in the history

  4. Updated AssetGenImage to also support parsing metadata into the gener… 

    …ated output.
    @bramp
    bramp committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    d5fdc31 View commit details
    Browse the repository at this point in the history

  5. Minor doc comment improvement, per PR feedback.

    @bramp
    bramp committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    811c952 View commit details
    Browse the repository at this point in the history

  6. Updated the README with information about the parse_metadata flag.

    @bramp
    bramp committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    2a2d8fa View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Update packages/core/lib/generators/integrations/integration.dart 

    Co-authored-by: Alex Li <[email protected]>
    @bramp @AlexV525
    bramp and AlexV525 authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    862d1bc View commit details
    Browse the repository at this point in the history