Implement Android Oboe audio error recovery mode. #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: FluidSynth#931 There is a new settings "audio.oboe.audio-error-recovery-mode" which has string value of "Reconnect" (default) or "Stop". Under `Reconnect` mode, it automatically recreate AudioStream for the same audio device ID (which is the default = valid device, unless a specific ID is specified). The behavior is the same as OpenSLES. In the future Fluidsynth might want to provide consistent error handling mode for audio device unplugged state, but so far this change makes apps behave not too weird.
derselbst
reviewed
Jul 13, 2021
- the default `Reconnect` option was missing from RECOVERY_MODE - ensure to reset `stream` field on "stop on error" mode. - changed some log verbosity values on device disconnection events.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #931
There is a new settings "audio.oboe.audio-error-recovery-mode" which has
string value of "Reconnect" (default) or "Stop".
Under
Reconnectmode, it automatically recreate AudioStream for thesame audio device ID (which is the default = valid device, unless a
specific ID is specified). The behavior is the same as OpenSLES.
In the future Fluidsynth might want to provide consistent error handling
mode for audio device unplugged state, but so far this change makes apps
behave not too weird.