Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on startup when there are no MIDI devices #1447

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

pedrolcl
Copy link
Contributor

@pedrolcl pedrolcl commented Dec 8, 2024

and autoconnect is enabled

Fix #1446

Copy link
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report + fix. Technically, this is a stack based underflow. Do we need to file a CVE for this? I don't see how it could be exploited though...

src/drivers/fluid_winmidi.c Outdated Show resolved Hide resolved
@pedrolcl
Copy link
Contributor Author

pedrolcl commented Dec 10, 2024

Thanks for the report + fix. Technically, this is a stack based underflow. Do we need to file a CVE for this? I don't see how it could be exploited though...

I don't believe so, but we may need to retire or replace the buggy v2.4.1 release asap. More interesting is why v2.4.0 is not affected but v2.4.1 crashes, when this line was included since v2.3.0 ?

Copy link

sonarcloud bot commented Dec 11, 2024

Copy link
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derselbst derselbst merged commit 0f308a9 into FluidSynth:master Dec 15, 2024
51 of 55 checks passed
@pedrolcl pedrolcl deleted the fix_1446 branch December 15, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in Windows when no MIDI device is available and autoconnect is enabled (Segmentation fault)
2 participants