-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: fix unicode support and build errors #1423
Windows: fix unicode support and build errors #1423
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Carlo!
* Required by Windows-specific sf_wchar_open() from | ||
* libsndfile that takes a UTF16_BE encoded filename. | ||
*/ | ||
#define ENABLE_SNDFILE_WINDOWS_PROTOTYPES 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ENABLE_SNDFILE_WINDOWS_PROTOTYPES is deprecated since v1.1.0:
https://github.com/libsndfile/libsndfile/blob/58c05b87162264200b1aa7790be260fd74c9deee/CHANGELOG.md?plain=1#L114
No description provided.