Convert fluidsynth CLI arguments #1421
Conversation
|
| for (i = 0; i < argc; ++i) | ||
| { | ||
| int u8_count = 0; | ||
| if (1 > (u8_count = WideCharToMultiByte(CP_UTF8, WC_ERR_INVALID_CHARS, wargv[i], -1, NULL, 0, NULL, NULL))) |
There was a problem hiding this comment.
@pedrolcl We have a minor oversight: WC_ERR_INVALID_CHARS is not available for WindowsXP, causing the CI to fail:
https://dev.azure.com/tommbrt/tommbrt/_build/results?buildId=10875&view=logs&j=ae601b3d-8756-52a4-4bcc-59c4d24c3f8c&t=1e42d489-b2c6-5e77-903e-6d797975357c&l=653
JJC needs WindowsXP compatibility. I haven't seen this earlier, because the build failed due to an issue in libinstpatch related to your bump of libsndfile min version: swami/libinstpatch#78
There was a problem hiding this comment.
Then, the only option is to replace the WC_ERR_INVALID_CHARS flag by 0.
There was a problem hiding this comment.
Would something like
#ifndef WC_ERR_INVALID_CHARS
#define WC_ERR_INVALID_CHARS 0
#endifmake sense, so that at least on modern Windows it reports a proper error?
Closes #1388