-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for absolute transform #1409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. A few comments below.
Also, a public interface for setting and getting the new transform field needs to be added as well. I.e.
fluid_mod_set_transform(fluid_mod_t *mod, int flags);
int fluid_mod_get_transform(const fluid_mod_t *mod);
Where flags
is an enum representing the two possible values. And with API documentation.
I've added enums and the checks you wanted. The functions are added too (with the comments), but if there's a separate .md or .xml file with the docs, I didn't find it. And lastly, check my comment regarding new_fluid_mod in your review. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tweaked the docs a bit and renamed the enums to be more consistent / easier to memorize. LGTM now, thanks!
Fixes #1391
This PR adds support for absolute value modulator transform.
Also fixes duplicated "to ensure" in a comment.