Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for absolute transform #1409

Merged
merged 5 commits into from
Oct 26, 2024

Conversation

spessasus
Copy link
Contributor

@spessasus spessasus commented Oct 18, 2024

Fixes #1391

This PR adds support for absolute value modulator transform.

Also fixes duplicated "to ensure" in a comment.

Copy link
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. A few comments below.

Also, a public interface for setting and getting the new transform field needs to be added as well. I.e.

fluid_mod_set_transform(fluid_mod_t *mod, int flags);
int fluid_mod_get_transform(const fluid_mod_t *mod);

Where flags is an enum representing the two possible values. And with API documentation.

src/sfloader/fluid_defsfont.c Outdated Show resolved Hide resolved
src/synth/fluid_mod.h Show resolved Hide resolved
src/synth/fluid_mod.c Outdated Show resolved Hide resolved
src/synth/fluid_mod.c Outdated Show resolved Hide resolved
@derselbst derselbst added this to the 2.4 milestone Oct 20, 2024
@spessasus
Copy link
Contributor Author

I've added enums and the checks you wanted. The functions are added too (with the comments), but if there's a separate .md or .xml file with the docs, I didn't find it. And lastly, check my comment regarding new_fluid_mod in your review.

Copy link

sonarcloud bot commented Oct 26, 2024

Copy link
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tweaked the docs a bit and renamed the enums to be more consistent / easier to memorize. LGTM now, thanks!

@derselbst derselbst merged commit 98b115f into FluidSynth:master Oct 26, 2024
46 of 54 checks passed
@spessasus spessasus deleted the absolute-transform branch October 26, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SF2.04 absolute value modulators
2 participants