[Cadence 1.0] - Update contracts, transactions and tests #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelipeRibeiroLabs
changed the title
austinkline
requested changes
Mar 13, 2024
| @@ -325,24 +324,20 @@ pub contract FlowtyRaffles { | |||
|
|
|||
| assert(raffle.revealers == nil || raffle.revealers![drawer.owner!.address] == true, message: "drawer is not permitted to perform reveals on this raffle") | |||
| let drawingResult = raffle.revealDrawing(id: receiptID) | |||
| let receipt = (&raffle.receipts[receiptID] as &Receipt?)! | |||
| let receiptCommitBlock = raffle.receipts[receiptID]!.commitBlock | |||
There was a problem hiding this comment.
Interesting! So array access on a resource gives us a reference now?
Comment on lines
+51
to
+53
| access(all) entitlement RevealRaffle | ||
|
|
||
| access(all) entitlement AddEntry |
There was a problem hiding this comment.
Let's move these two further up in the file itself, most of the time I see these right after event definitions
We should also add some comments about each entitlement and what it's for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.