-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: upload dialog with configurable additional property fields #165
base: main
Are you sure you want to change the base?
FEATURE: upload dialog with configurable additional property fields #165
Conversation
975e671
to
79ad94d
Compare
79ad94d
to
277cc45
Compare
c98fbd6
to
94ddbc0
Compare
…oad dialogs, improve UX
94ddbc0
to
2b1f31f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cannot be merged without the necessary core change, which I assume could now target 9.0 or 9.1, but the Media.UI itself is not compatible with 9.x yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this huge change.
But several adjustments are necessary which will also make this change cleaner.
I haven't checked everything yet, so I will add further comments when I see issues.
Resources/Private/JavaScript/media-module/src/components/SideBarRight/Inspector/Property.tsx
Outdated
Show resolved
Hide resolved
.../Private/JavaScript/media-module/src/components/SideBarRight/Inspector/PropertyInspector.tsx
Show resolved
Hide resolved
Resources/Private/JavaScript/asset-upload-screen/src/AssetUploadScreen.tsx
Show resolved
Hide resolved
Resources/Private/JavaScript/asset-upload/src/components/FilePreview.module.css
Outdated
Show resolved
Hide resolved
Resources/Private/JavaScript/asset-upload/src/components/FilePreview.module.css
Show resolved
Hide resolved
Resources/Private/JavaScript/asset-upload/src/components/FilePreview.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to not have any compiled files in the PRs as they add much data to the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand your opinion, but how else should I make the changes functionally available. Without the built files, you can't simply check out the branch and use it in your project. In order to be able to use the changes easily, I think it makes sense to commit the built files as well. Still, I am open to suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use the branch actively you should have a separate branch with the bundles as the default behaviour often is also to delete branches on merge which would break your project.
Then you update your "production" branch from this one on changes and rebuild.
In this PR you committed the bundles several times which are quite a bit of size to the repo. It's a bit annoying but I see no better way and I've been looking for a better way since quite a while.
Hallo @Sebobo, thank you very much for your feedback. I adjust some of my changes and left additional explanations to your comments. Feel free to give me further feedback. Thank you. |
Hi Andre, thx! |
Resources/Private/JavaScript/asset-upload/src/components/FilePreview.module.css
Outdated
Show resolved
Hide resolved
Resources/Private/JavaScript/asset-upload/src/components/FilePreview.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use the branch actively you should have a separate branch with the bundles as the default behaviour often is also to delete branches on merge which would break your project.
Then you update your "production" branch from this one on changes and rebuild.
In this PR you committed the bundles several times which are quite a bit of size to the repo. It's a bit annoying but I see no better way and I've been looking for a better way since quite a while.
…or NewAssetUploaddialog, adjust css and logic in FIlePreview
Hi @Sebobo I adjusted the components and styling as you suggested. I only committed my code changes, but no builds to not further increase the size of my pr unnecessarily. I also did not rebase to the latest main. Please take a look at the changes and let me know, if there are still problems. Please contact me as soon as you are ready to merge my changes, so that I can rebase my branch. Please also contact me if you have any further questions. Thank you very much. |
@andrehoffmann30 thank your! I plan to review again end of this week or start of next. |
Hi @Sebobo , have you had time to check my latest adjustments? Please let me know if I can help you in any way. Thank you. |
What I did
I adjusted the upload dialog. It is now possible to configure additonal property filed sto collect the information while uploading a news file. The new new upload dialog is used in the backend module and ind the content area.
How I did it
For the backend module I adjusted the existing upload dialog to respect the new configuration options and handel the rendering and file upload logic accordinglly. For the Content area i added a
MediaUploadScreen
as a scondary editor to render and handle the file upload like in the bakcend module. For thsi to function also an adjustment of the image editor is needed (see neos/neos-ui#3302 ).How to verify it
Configure the fileds according to the example in the read me, than the uplaod dialog should render the new additional fields and bahave as configured.