BUGFIX: The CORS middleware will create the response for an OPTIONS request without passing the request down through the process chain #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mficzel
force-pushed
the
bugfix/handlePreflightInCorsMiddleware
branch
3 times, most recently
from
56d31eb to
5437de6
Compare
…equest without passing the request down through the process chain Without this change the preflight lead to a 404 as the OPTIONS request could not be routed which yielded a 404 exception.
mficzel
force-pushed
the
bugfix/handlePreflightInCorsMiddleware
branch
from
5437de6 to
10e5bf8
Compare
t-heuser
requested changes
Dec 10, 2024
|
@mficzel Merged and released :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change the preflight lead to a 404 as the OPTIONS request could not be routed which yielded a 404 exception.