Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: Send a File to Node-RED #1445

Merged
merged 30 commits into from
Jan 5, 2024
Merged

Blog: Send a File to Node-RED #1445

merged 30 commits into from
Jan 5, 2024

Conversation

gdziuba
Copy link
Contributor

@gdziuba gdziuba commented Jan 2, 2024

To Do

  • Art
  • Finish Blog
  • Upload to Git
    • Readme on git
  • update Flow on Node-RED website with link to blog
  • Release 24/01/03

Description

Related Issue(s)

close #1446
close #1368
close #1467

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

@gdziuba gdziuba self-assigned this Jan 2, 2024
@gdziuba gdziuba marked this pull request as draft January 2, 2024 17:54
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Images automagically compressed by Calibre's image-actions

Compression reduced images by 35.8%, saving 6.04 KB.

Filename Before After Improvement Visual comparison
src/blog/2024/01/images/csv_upload_app.png 16.86 KB 10.82 KB -35.8% View diff

682 images did not require optimisation.

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Images automagically compressed by Calibre's image-actions

Compression reduced images by 34.8%, saving 6.66 KB.

Filename Before After Improvement Visual comparison
src/blog/2024/01/images/nr_flow_csv_ingress.png 19.14 KB 12.47 KB -34.8% View diff

683 images did not require optimisation.

@gdziuba
Copy link
Contributor Author

gdziuba commented Jan 2, 2024

Blog to go out 24/01/03

@gdziuba gdziuba requested a review from Hasmin-AC January 2, 2024 20:02
@gdziuba gdziuba marked this pull request as ready for review January 2, 2024 20:10
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Images automagically compressed by Calibre's image-actions

Compression reduced images by 32.2%, saving 11.15 KB.

Filename Before After Improvement Visual comparison
src/blog/2024/01/images/csv-dashboard.png 34.61 KB 23.46 KB -32.2% View diff

687 images did not require optimisation.

@gdziuba gdziuba requested a review from ZJvandeWeg January 4, 2024 16:56
src/blog/2024/01/send-a-file.md Outdated Show resolved Hide resolved
@gdziuba gdziuba requested a review from Hasmin-AC January 4, 2024 17:27
Co-authored-by: Zeger-Jan van de Weg <[email protected]>
Co-authored-by: Zeger-Jan van de Weg <[email protected]>
gdziuba and others added 4 commits January 4, 2024 13:27
Co-authored-by: Zeger-Jan van de Weg <[email protected]>
Co-authored-by: Zeger-Jan van de Weg <[email protected]>
Co-authored-by: Zeger-Jan van de Weg <[email protected]>
Co-authored-by: Zeger-Jan van de Weg <[email protected]>
@ZJvandeWeg
Copy link
Member

@gdziuba I don't think we should keep the python app like discussed in our 1:1. Dashboard is the easiest way to set up, configure, and maintain. It's also portable (windows, Unix, hack even *BSD). I vote this article is just about Dashboard, no python, git, and all the others.

@gdziuba
Copy link
Contributor Author

gdziuba commented Jan 4, 2024

@gdziuba I don't think we should keep the python app like discussed in our 1:1. Dashboard is the easiest way to set up, configure, and maintain. It's also portable (windows, Unix, hack even *BSD). I vote this article is just about Dashboard, no python, git, and all the others.

@ZJvandeWeg So, the main intention behind this blog was to answer a Google query - "How to send a file to Node-RED?" - for SEO purposes. However, we've now removed all the Python code from the blog, which makes the original title seem a bit off. A more suitable title would be "How to import a file into Node-RED." But, if we use this title, it could defeat the purpose of our SEO goal. I can go either way. I just want to make sure we are on the same page before I delete the python portion.

@gdziuba
Copy link
Contributor Author

gdziuba commented Jan 4, 2024

@ZJvandeWeg

What about splitting up into two blogs. With them linking to each other?

One Titled:
"Send a File to a Node-RED"
"Import a File into Node-RED with Dashboard 2.0"

@ZJvandeWeg
Copy link
Member

ZJvandeWeg commented Jan 4, 2024 via email

@ZJvandeWeg ZJvandeWeg enabled auto-merge January 5, 2024 12:01
@ZJvandeWeg ZJvandeWeg disabled auto-merge January 5, 2024 12:03
@ZJvandeWeg ZJvandeWeg merged commit 655de6c into main Jan 5, 2024
6 checks passed
@ZJvandeWeg ZJvandeWeg deleted the gdziuba-send-a-file branch January 5, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants