Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure restart on done only a running NR instance #304

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Ensure restart on done only a running NR instance #304

merged 3 commits into from
Dec 13, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Dec 4, 2024 •
edited
Loading

part of FlowFuse/flowfuse#4839

Description

Prevents the restart command from running if the Node-RED instance is not actually running

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb self-assigned this Dec 4, 2024
@hardillb hardillb changed the title Ensure restart on done on a running NR instance Ensure restart on done only a running NR instance Dec 4, 2024
@hardillb hardillb marked this pull request as ready for review December 6, 2024 17:56
@hardillb hardillb requested a review from knolleary December 6, 2024 17:56
@knolleary
Copy link
Member

If NR isn't running, should the restart command skip the 'stop' bit, but still do the 'start' bit (if the current state is something expected?)

hardillb
hardillb commented Dec 10, 2024
View reviewed changes
lib/admin.js Outdated Show resolved Hide resolved
@hardillb
Copy link
Contributor Author

That is a valid thought. Will have a look

@knolleary knolleary merged commit 4bbf9cd into main Dec 13, 2024
5 checks passed
@knolleary knolleary deleted the restart-hang branch December 13, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardillb @knolleary