-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass at file api #275
Conversation
Quick one - as discussed in eng meeting. the regex on the routes block valid file names and paths that for example contain a space. |
Also consolidate the regex into the single variable to make changes easier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check your linter settings? lib/files/index.js
has a bunch of minor formatting issues that eslint is flagging.
Some other comments along the way.
hmm, lint settings should be checked into the project and it' passes when I run |
Co-authored-by: Nick O'Leary <[email protected]>
The npm task is incorrectly configured: https://github.com/FlowFuse/nr-launcher/blob/main/package.json#L23-L24 It is linting |
Add test that dir exists for file upload
Config httpStatic based on instance settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reviewed and pulled locally by myself and @joepavitt - all goodness and working.
Approving (with blessing) and acknowledge there are no new tests for the new files api and runtimesettings changes) for which I will add a follow up chore issue.
fixes #273
Description
Implement API from FlowFuse/flowfuse#4357
Related Issue(s)
#273
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label