Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add nr-assistant dependency to build and push workflow #260

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

ppawlowski
Copy link
Contributor

@ppawlowski ppawlowski commented Jul 4, 2024

Description

This pull requests adds @flowfuse/nr-assistant to the list of dependencies required during nightly build of nr-launcher package.
Additionally, it updates reusable workflows to their latest versions.

Related Issue(s)

closes #259

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested review from hardillb and Steve-Mcl July 4, 2024 07:43
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Piotr, does this not need a section similar to what project nodes have?

https://github.com/FlowFuse/nr-launcher/pull/260/files#diff-551d1fcf87f78cc3bc18a7b332a4dc5d8773a512062df881c5aba28a6f5c48d7L6-L9

      nr_project_nodes_release_name:
        description: 'nr-project-nodes package version'
        required: false
        default: 'nightly'

@ppawlowski
Copy link
Contributor Author

Piotr, does this not need a section similar to what project nodes have?

https://github.com/FlowFuse/nr-launcher/pull/260/files#diff-551d1fcf87f78cc3bc18a7b332a4dc5d8773a512062df881c5aba28a6f5c48d7L6-L9

      nr_project_nodes_release_name:
        description: 'nr-project-nodes package version'
        required: false
        default: 'nightly'

Nope, it is a workflow "feature" which we never implemented. However, we might use it in the near future, that is why it is still there.

@Steve-Mcl Steve-Mcl self-requested a review July 4, 2024 08:07
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From settings values PoV, i approve but will leave open for Ben to review and merge.

@hardillb hardillb merged commit e666cd8 into main Jul 4, 2024
5 checks passed
@hardillb hardillb deleted the ci-nr-assistant-dep-workflow branch July 4, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update .github/workflows/publish.yml for nr-assistant
3 participants