Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi Tenancy: Ensure all conditions are met defined in _client constraints #977

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Multi Tenancy: Ensure all conditions are met defined in _client constraints #977

merged 1 commit into from
Jun 14, 2024

Conversation

joepavitt
Copy link
Collaborator

@joepavitt joepavitt commented Jun 14, 2024 •
edited
Loading

Description

  • Previously if a plugin was running, which appended a user object, we then only considered the user object important when checking which connections to send data to.
  • Now, we consider both user and socketId still, so a user logged in on multiple sessions would not have shared data (unless their msg._client.socketId is removed in the msg)
  • Add new "Multi Tenancy" section for docs

Related Issue(s)

Closes #947

@joepavitt joepavitt requested a review from cstns June 14, 2024 13:44
@joepavitt joepavitt merged commit 2cb8ca9 into main Jun 14, 2024
1 of 2 checks passed
@joepavitt joepavitt deleted the 947-client-constraints branch June 14, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstns cstns cstns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard 1.11.1 msg._client issues (!)
2 participants
@joepavitt @cstns