Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget Sync - Add new widget-sync event #1463

Merged
merged 8 commits into from
Dec 4, 2024
Merged

Widget Sync - Add new widget-sync event #1463

merged 8 commits into from
Dec 4, 2024

Conversation

joepavitt
Copy link
Collaborator

@joepavitt joepavitt commented Nov 13, 2024

Description

  • Adds new widget-sync event
  • Updates Events Architecture & in-app helper text to detail the new functionality
  • The new event ensure that multiple clients all reflect the single source of truth, without a need to refresh the page
  • This functionality is locked behind the same validClient test that the msg._client data is, so that functionality is now a consistent "single source of truth" vs. "separate clients" toggle.

Notes

I will be following this up with #1294 as it'll clean the custom onSync functions out entirely, but was no need to merge it all together in the name of iteration.

Related Issue(s)

Closes #679

@joepavitt joepavitt requested a review from Steve-Mcl November 13, 2024 10:15
@joepavitt joepavitt mentioned this pull request Nov 22, 2024
10 tasks
docs/contributing/guides/events.md Outdated Show resolved Hide resolved
ui/src/widgets/data-tracker.mjs Show resolved Hide resolved
ui/src/widgets/ui-switch/UISwitch.vue Outdated Show resolved Hide resolved
ui/src/widgets/ui-slider/UISlider.vue Outdated Show resolved Hide resolved
ui/src/widgets/ui-number-input/UINumberInput.vue Outdated Show resolved Hide resolved
@joepavitt joepavitt requested a review from Steve-Mcl November 29, 2024 16:52
@joepavitt joepavitt merged commit 85a9cf1 into main Dec 4, 2024
1 of 2 checks passed
@joepavitt joepavitt deleted the 679-sync-widgets branch December 4, 2024 16:34
@bartbutenaers bartbutenaers mentioned this pull request Jan 9, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clients get out of sync from centralised datastore
3 participants