cannot play without src

FlowFuse · Dec 4, 2024 · eb0438a · eb0438a
1 parent 95a9d8a
commit eb0438a
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/nodes/widgets/ui_audio.js b/nodes/widgets/ui_audio.js
@@ -1,3 +1,4 @@
+const datastore = require('../store/data.js')
 const statestore = require('../store/state.js')
 
 module.exports = function (RED) {
@@ -11,7 +12,26 @@ module.exports = function (RED) {
 
         const evts = {
             onAction: true,
+            onInput: function (msg, send) {
+                // store the latest msg passed to node, only if a source is supplied in the payload
+                if (typeof msg.payload === 'string') {
+                    datastore.save(group.getBase(), node, msg)
+                }
+                // only send msg on if we have passthru enabled
+                if (config.passthru) {
+                    send(msg)
+                }
+            },
             beforeSend: function (msg) {
+                if (msg.playback === 'play') {
+                    const lastMsg = datastore.get(node.id)
+                    // TODO zou eigenlijk de last message met een payload moeten zijn.
+                    const src = lastMsg?.payload || config.src
+                    if (typeof src !== 'string' || src.trim() === '') {
+                        node.warn('Cannot play audio when no source has been specified')
+                    }
+                }
+
                 if (msg.ui_update) {
                     const updates = msg.ui_update
 

diff --git a/ui/src/widgets/ui-audio/UIAudio.vue b/ui/src/widgets/ui-audio/UIAudio.vue
@@ -96,13 +96,17 @@ export default {
 
             switch (msg.playback) {
             case 'play':
-                this.$refs.audio.play()
+                this.$refs.audio.play().catch((err) => {
+                    console.error('Error playing audio:', err)
+                })
                 break
             case 'stop':
                 this.$refs.audio.src = ''
                 break
             case 'pause':
-                this.$refs.audio.pause()
+                this.$refs.audio.pause().catch((err) => {
+                    console.error('Error pausing audio:', err)
+                })
                 break
             }
         },