Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a team level device groups UI #5018

Merged
merged 12 commits into from
Jan 15, 2025
Merged

Add a team level device groups UI #5018

merged 12 commits into from
Jan 15, 2025
+310 −2

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Jan 15, 2025

Description

Add a team level device groups UI

Related Issue(s)

closes #4874

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns requested a review from joepavitt January 15, 2025 16:56
@cstns cstns mentioned this pull request Jan 15, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.40%. Comparing base (9220a06) to head (c501f79).
Report is 16 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5018   +/-   ##
=======================================
  Coverage   78.40%   78.40%           
=======================================
  Files         329      329           
  Lines       15478    15478           
  Branches     3574     3574           
=======================================
  Hits        12136    12136           
  Misses       3342     3342
Flag Coverage Δ
backend 78.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary
Copy link
Member

Some basic click testing looks good.

  • Created a new Device Group from the new view - worked as expected
  • Correctly shows 'feature not available' when viewed on a team without groups enabled

Some on-screen text to tidy up following the 'Device' -> 'Remote Instance' renaming. We need to decide whether to standardise on 'remote Instance' or 'Remote Instance'. Not a blocker, but want to take another look at that part in the morning.

Functionally, all looks good 👍🏻

knolleary
knolleary approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending a couple device -> instance updates

frontend/src/pages/team/DeviceGroups/index.vue Outdated Show resolved Hide resolved
frontend/src/pages/team/DeviceGroups/index.vue Show resolved Hide resolved
frontend/src/pages/team/DeviceGroups/index.vue Show resolved Hide resolved
@cstns
Copy link
Contributor Author

cstns commented Jan 15, 2025

I'll add e2e tests tomorrow

@cstns cstns merged commit a08ba1b into main Jan 15, 2025
20 checks passed
@cstns cstns deleted the add-a-team-level-device-groups-ui branch January 15, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

@joepavitt joepavitt Awaiting requested review from joepavitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Team Level: (Device) Groups
2 participants
@cstns @knolleary