Disable caching of index.html when in dev mode #5017
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When telemetry (ie sentry) is enabled, the app loads
index.html
and injects the necessary scripts - and then caches the result for subsequent requests.When running in dev mode (ie
npm run serve
), webpack rewrites index.html with the new content hashes applied. However, the forge app still serves the cached version - causing errors.This fix disables the caching of index.html when telemetry is enabled and we're running in development mode. We know we're dev mode as
NODE_ENV
is set todevelopment
by the npm scripts.