Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve feedback when Hosted Instances are not available to a team #4956

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Dec 23, 2024

Description

Improves communication to user that Hosted Instances are unavailable on their Free Tier, as well as refining the UX path to Devices when a new Application is created and prevent the current confusion caused by users being redirected to /instances when it's not something they're able to use.

  • Shows a "Premium" flag for "Hosted Instances" in the side navigation when 0 instances are permitted on tat given Team Type
  • Auto-redirects to the ApplicationDevices screen when navigating to the base page for an Application, if no Instances are allowed to be created. This includes newly created applications on the Free Tier.
  • Ensure we show the "Feature Unavailable" banner on the Application - Instances page if a user does navigate there
  • Fix the router-link :to fields for the Instance and Device empty state placeholders on the Applications home page
  • Prevent the option for "Create Node-RED Instance" when creating a new application in a team that isn't permitted to create an instance
  • Prevent option to "Create Instance with Application" if the Team Tier does not permit it
  • Improve language in the help text

Screenshots

Screenshot 2024-12-23 at 12 47 19 Screenshot 2024-12-23 at 12 47 37

Related Issue(s)

Closes #4955

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.44%. Comparing base (d29e97d) to head (0c84d0a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4956   +/-   ##
=======================================
  Coverage   78.44%   78.44%           
=======================================
  Files         325      325           
  Lines       15353    15353           
  Branches     3529     3529           
=======================================
  Hits        12043    12043           
  Misses       3310     3310           
Flag Coverage Δ
backend 78.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cstns cstns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, would love some basic e2e coverage nothing fancy. I'll approve the pr as is and you can add the tests later as i won't be here to approve

@joepavitt joepavitt merged commit aa77197 into main Dec 23, 2024
18 checks passed
@joepavitt joepavitt deleted the 4955-no-instances-feedback branch December 23, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Free Tier Onboarding: Hosted Instances Feature Flag
2 participants