-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Dashboard and Editor links in new tab by default #4923
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4923 +/- ##
=======================================
Coverage 78.63% 78.63%
=======================================
Files 324 324
Lines 15265 15265
Branches 3507 3507
=======================================
Hits 12003 12003
Misses 3262 3262
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Given the test failure, I think the best course of action is to remove that test given that we can't test for a new tab URL in Cypress @cstns thoughts? |
Yes, That would be the only way to do it. |
While atampting to remvoe the failing test, cypress blatantly opened a new window without crashing. I'll need a couple of minutes to see what we can do here, afaik this was a known limitation |
It is listed as a permanent trade-off for Cypress, i.e. something they'll never support |
managed to get a partial win, by stubbing the window open i was able to at least verify that the window opens with the correct url |
Description
target
to prevent duplication of opened tabsRelated Issue(s)
Closes #4727