Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Dashboard and Editor links in new tab by default #4923

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

joepavitt
Copy link
Contributor

Description

  • Modifies the underlying Dashboard and Editor Link components to open the respective links in a new tab
  • Ensure we're utilising target to prevent duplication of opened tabs

Related Issue(s)

Closes #4727

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.63%. Comparing base (bdf5dae) to head (ac9b3cf).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4923   +/-   ##
=======================================
  Coverage   78.63%   78.63%           
=======================================
  Files         324      324           
  Lines       15265    15265           
  Branches     3507     3507           
=======================================
  Hits        12003    12003           
  Misses       3262     3262           
Flag Coverage Δ
backend 78.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt
Copy link
Contributor Author

Given the test failure, I think the best course of action is to remove that test given that we can't test for a new tab URL in Cypress

@cstns thoughts?

@cstns
Copy link
Contributor

cstns commented Dec 17, 2024

Given the test failure, I think the best course of action is to remove that test given that we can't test for a new tab URL in Cypress

@cstns thoughts?

Yes, That would be the only way to do it.

@cstns
Copy link
Contributor

cstns commented Dec 17, 2024

While atampting to remvoe the failing test, cypress blatantly opened a new window without crashing. I'll need a couple of minutes to see what we can do here, afaik this was a known limitation

@joepavitt
Copy link
Contributor Author

It is listed as a permanent trade-off for Cypress, i.e. something they'll never support

@cstns
Copy link
Contributor

cstns commented Dec 17, 2024

managed to get a partial win, by stubbing the window open i was able to at least verify that the window opens with the correct url

@cstns cstns merged commit be3af14 into main Dec 17, 2024
18 checks passed
@cstns cstns deleted the 4727-nr-new-tab branch December 17, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-open NR Editors in New Tab
2 participants