-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support disabling instance launcher "auto safe mode" #4922
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4922 +/- ##
==========================================
+ Coverage 78.63% 78.65% +0.02%
==========================================
Files 324 324
Lines 15265 15280 +15
Branches 3507 3513 +6
==========================================
+ Hits 12003 12018 +15
Misses 3262 3262
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need a nr-launcher version gate on showing the settings so the user knows to upgrade the stack to enable the feature
Also when I toggle the checkbox the "save settings" button is not being enabled (or changing the health check timeout) The |
…om/FlowFuse/flowfuse into 4920-disable-auto-safe-mode-option
That was working for me, but good spot on missing data entries (now added) |
Toggling the checkbox is still now marking the save settings button as active |
@Steve-Mcl take hte 5000 out of the box at the top, the default is empty |
Ah, ok. This was existing behaviour but now there is more than one setting on the form, it matters! I'll modify the form to show the default health value so the validation works. |
ok, fingers crossed, 3rd time is sure to be the charm. I've added the v-else message that some settings are not available until stack is upgraded. I set the local health value input to the launchers default (even if not set in the DB settings) - this way, there are no validation errors and the Auto Safe Mode toggle can be operated/changed/saved. Lastly I made sure settings are only passed/updated if changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But not merging as the updated stacks won't be available until release.
We should merge this on release day along with #4900
closes #4920
Description
Adds setting for launcher:
disableAutoSafeMode
Updates UI to permit setting of
disableAutoSafeMode
Updates unit test to ensure value is persisted
Related Issue(s)
owner: #4920
parent: #4552
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label