Remove notifications for deleted instances

[hardillb]

fixes #4845

Description

Adds afterDestroy hook to Projects table remove Notifications when Instances are deleted.

Also includes a migration to remove orphaned Notifications.

Related Issue(s)

#4845

Checklist

• I have read the contribution guidelines
• Suitable unit/system level tests have been added and they pass
• Documentation has been updated
  • Upgrade instructions
  • Configuration details
  • Concepts
• Changes flowforge.yml?
  • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
  • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

• Includes a DB migration? -> add the area:migration label

[hardillb]

We should probably do Devices as well, but want the approach verifying first

[codecov]

Codecov Report

Attention: Patch coverage is 39.13043% with 14 lines in your changes missing coverage. Please review.

Project coverage is 78.64%. Comparing base (6f512d8) to head (3344565).
Report is 127 commits behind head on main.

Files with missing lines	Patch %	Lines
.../20241209-01-remove-dead-instance-notifications.js	36.36%	14 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4899      +/-   ##
==========================================
- Coverage   78.74%   78.64%   -0.10%     
==========================================
  Files         323      324       +1     
  Lines       15221    15254      +33     
  Branches     3496     3501       +5     
==========================================
+ Hits        11986    11997      +11     
- Misses       3235     3257      +22     

Flag	Coverage Δ
backend	78.64% <39.13%> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[knolleary]

Can we look at doing a bulk delete sql rather than lots of individual ones?

https://sequelize.org/docs/v7/querying/delete/#deleting-in-bulk

[hardillb]

I'll have another look, but we only have raw SQL access at this point (none of the models are loaded when the migrations run).

And the Notification table doesn't have a bare field with the project id that would could do a WHERE "projectId" NOT IN (SELECT "id" from Projects)

[knolleary]

Good point; the reference field doesn't lend itself to using with in.

[knolleary]

Issue with the count query across both support db flavours.