Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Enable proxy protocol on ingress-nginx controller installation #4082

Merged
merged 7 commits into from
Jul 4, 2024
Merged

docs: Enable proxy protocol on ingress-nginx controller installation #4082

merged 7 commits into from
Jul 4, 2024

Conversation

ppawlowski
Copy link
Contributor

Description

This pull request updates the ingress-nginx controller installation procedure by adding a properties to enable PROXY protocol in:

  • nginx configuration
  • AWS NLB configuration
  • DigitalOcean LB configuration

Related Issue(s)

#3800

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested review from hardillb and knolleary July 1, 2024 17:22
@ppawlowski ppawlowski changed the title doc: Enable proxy protocol on ingress-nginx controller installation docs: Enable proxy protocol on ingress-nginx controller installation Jul 1, 2024
@knolleary
Copy link
Member

Do we have any actual documentation/upgrade guides for this? Adding the config to the examples is fine, but not going to be something we can point users at to help them upgrade.

@knolleary knolleary mentioned this pull request Jul 3, 2024
Closed
hardillb
hardillb reviewed Jul 4, 2024
View reviewed changes
Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed a bit in the ingress-nginx config example in the upgrade docs.

docs/upgrade/README.md Outdated Show resolved Hide resolved
@ppawlowski ppawlowski requested a review from hardillb July 4, 2024 09:35
@ppawlowski ppawlowski marked this pull request as ready for review July 4, 2024 09:36
hardillb
hardillb approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we can iterate on the language if needed.

knolleary
knolleary reviewed Jul 4, 2024
View reviewed changes
docs/upgrade/README.md Outdated Show resolved Hide resolved
@hardillb hardillb mentioned this pull request Jul 4, 2024
Merged
@knolleary knolleary merged commit 33899f3 into main Jul 4, 2024
13 checks passed
@knolleary knolleary deleted the docs-aws-lb-proxy branch July 4, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardillb hardillb hardillb approved these changes

@knolleary knolleary knolleary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ppawlowski @knolleary @hardillb