Add support for ingress tls entry #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
part of #83 Basic TLS ingress entry
|
Should have the tls section refer to a specific secret for the ca certificates. I don't know if nginx-ingress can reference/use a configMap (ff-ca-certs), looks like it only supports secrets. ? |
dfulgham
reviewed
Jul 14, 2023
| hosts: [ | ||
| url.host | ||
| ] | ||
| }] |
There was a problem hiding this comment.
secretName: "ff-apps-ca-secret"
Or something, to hold the wildcard ca certificate to be used for applications, would need to be documented.
There was a problem hiding this comment.
ff-apps-ca-secrets is not a Secret, it's a collection of CA certs that the instance should trust, so not useful here.
I'm still working out how to solve this nicely, there are 2 possible approaches
- A single shared wildcard cert/key in a single secret
- A secret per instance, and something like CertManager issuing new ACME provisioned certs for each.
Both have pros/cons for different environments.
Still not sure how we will populate this, or if it should point to a shared wildcard cert
|
superseded by #131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #83
Basic TLS ingress entry
Description
Related Issue(s)
#83
Checklist
flowforge.yml?flowforge/helmto update ConfigMap Templateflowforge/CloudProjectto update values for Staging/ProductionLabels
backportlabelarea:migrationlabel