Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Hostname support #151

Merged
merged 18 commits into from
Jun 5, 2024
Merged

Custom Hostname support #151

merged 18 commits into from
Jun 5, 2024

Conversation

hardillb
Copy link
Contributor

part of FlowFuse/flowfuse#324

Description

Adds support to create the extra ingress object for an intances custom hostname

Related Issue(s)

FlowFuse/flowfuse#324

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb self-assigned this Apr 24, 2024
@hardillb hardillb mentioned this pull request May 7, 2024
Closed
@hardillb hardillb requested a review from knolleary May 29, 2024 10:47
@hardillb hardillb marked this pull request as ready for review May 29, 2024 10:47
knolleary
knolleary reviewed May 29, 2024
View reviewed changes
kubernetes.js Outdated Show resolved Hide resolved
hardillb and others added 2 commits May 29, 2024 16:17
@hardillb hardillb requested a review from knolleary May 29, 2024 15:19
knolleary
knolleary requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to tidy up the logging - we shouldn't add more uses of 'project'

kubernetes.js Outdated Show resolved Hide resolved
@knolleary knolleary self-requested a review June 5, 2024 12:56
@knolleary knolleary merged commit 075dafb into main Jun 5, 2024
3 checks passed
@knolleary knolleary deleted the custom-hostname branch June 5, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardillb @knolleary