Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy code that is not used anymore #144

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

hardillb
Copy link
Contributor

Description

We left the code for creating raw pods when we moved to creating deployments.

This is to prevent confusion when making updates to the k8s artefacts (e.g. making changes to the unused createPod() code

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

This is to prevent confusion when making updates to the k8s
artefacts
@hardillb hardillb requested a review from knolleary March 27, 2024 15:02
@hardillb hardillb self-assigned this Mar 27, 2024
@knolleary knolleary merged commit ed72f4f into main Mar 27, 2024
3 checks passed
@knolleary knolleary deleted the remove-unused-code branch March 27, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants