Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run promises in order #115

Merged
merged 15 commits into from
Oct 18, 2023
Merged

Run promises in order #115

merged 15 commits into from
Oct 18, 2023

Conversation

hardillb
Copy link
Contributor

Description

possible for creating/deleting k8s artefacts to fail if done out of order or too quickly.

Related Issue(s)

#114

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb self-assigned this Sep 25, 2023
@hardillb
Copy link
Contributor Author

@elenaviter This is still work in progress, but if you get a moment can you cast an eye of these changes. (open question is how long to wait when polling)

@elenaviter
Copy link
Contributor

Hello @hardillb,
I've opened followup PR on this same branch.
The code was staged on our systems and shown the problems it address are solved:

  • suspend/start project is not guaranteed to succeed
  • projects auth token deteriorates after FF upgrade

We are aiming to integrate it at the earliest convenience.
Thank you in advance for considering our request! We are looking forward to your valuable feedback.

@hardillb hardillb marked this pull request as ready for review October 13, 2023 09:24
@hardillb hardillb requested a review from ppawlowski October 13, 2023 10:31
@hardillb hardillb added this to the 1.13 milestone Oct 13, 2023
@hardillb
Copy link
Contributor Author

I've tested this locally on my K8s rig and it looks good so far.

@hardillb
Copy link
Contributor Author

@ppawlowski when you get moment can you review this so I can deploy it to staging for more testing. Thanks

@hardillb hardillb requested review from Pezmc and knolleary and removed request for ppawlowski October 16, 2023 11:55
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted some intervals that wouldn't be stopped in case of an error.

kubernetes.js Outdated Show resolved Hide resolved
kubernetes.js Outdated Show resolved Hide resolved
kubernetes.js Outdated Show resolved Hide resolved
hardillb and others added 3 commits October 18, 2023 10:03
Co-authored-by: Nick O'Leary <[email protected]>
Co-authored-by: Nick O'Leary <[email protected]>
Co-authored-by: Nick O'Leary <[email protected]>
@hardillb hardillb requested a review from knolleary October 18, 2023 09:21
@Pezmc Pezmc removed their request for review October 18, 2023 10:55
@knolleary knolleary merged commit f418b0d into main Oct 18, 2023
4 checks passed
@knolleary knolleary deleted the fix-creation-race-114 branch October 18, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants