-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run promises in order #115
Conversation
Part of #114
@elenaviter This is still work in progress, but if you get a moment can you cast an eye of these changes. (open question is how long to wait when polling) |
Hello @hardillb,
We are aiming to integrate it at the earliest convenience. |
Fix creation race 114
I've tested this locally on my K8s rig and it looks good so far. |
@ppawlowski when you get moment can you review this so I can deploy it to staging for more testing. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted some intervals that wouldn't be stopped in case of an error.
Co-authored-by: Nick O'Leary <[email protected]>
Co-authored-by: Nick O'Leary <[email protected]>
Co-authored-by: Nick O'Leary <[email protected]>
Description
possible for creating/deleting k8s artefacts to fail if done out of order or too quickly.
Related Issue(s)
#114
Checklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label