Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Plugin: Unity projects launcher #431

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

Ghost-Miner
Copy link
Contributor

plugin to open unity projects from the kauncher.

exiting plugins for this purpose no longer work and are abandoned or cancelled.

…to Unity Projects Launcher-8de584c0-f855-4825-8886-65e670ebe441.json
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please publish the release with GitHub action workflow.

@Ghost-Miner
Copy link
Contributor Author

How do you do that? There's no guide for C# and the file I made doesn't seem to work.

@jjw24
Copy link
Member

jjw24 commented Dec 15, 2024

You are right, we are actually missing how to setup workflow for .Net plugins.

You almost got it, it's not triggering because the push rule is for master branch, your repo has main branch instead. So just need to change this line https://github.com/Ghost-Miner/Unity-project-launcher-plugin/blob/7ac9204725eef94b32071249d634cc2dd4963396/.github/workflows/Publish%20Release.yml#L5

@Ghost-Miner
Copy link
Contributor Author

so i uploaded a working workflow file, but now it always throws "path" not found and either doesnt tell me the full path at all or hides it buried somewhere

@Ghost-Miner
Copy link
Contributor Author

so i uploaded a working workflow file, but now it always throws "path" not found and either doesnt tell me the full path at all or hides it buried somewhere

It looks like i finally got the workflow working.

@Ghost-Miner Ghost-Miner requested a review from jjw24 December 16, 2024 16:56
@jjw24 jjw24 merged commit 80723cb into Flow-Launcher:plugin_api_v2 Dec 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants