Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an incorrect duplicate plugin file #430

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

Yusyuriv
Copy link
Member

I don't know much about the way the manifest works, but as far as I know, simply deleting the plugin file should be enough. Correct me if I'm wrong.

Seems like the original file was named incorrectly. It's called Nightlight-95af3946-2bfe-49af-a9b6-edffa42ef1d5.json but the id inside is ef3a6ece-ca05-4d4f-92ba-2ff8a67e017b. Update workflow then writes the new file with the correct name, but the old file is still there, causing infinite update notifications.

@Yusyuriv Yusyuriv requested review from Garulf and taooceros December 13, 2024 16:34
@Yusyuriv Yusyuriv self-assigned this Dec 13, 2024
@Garulf Garulf merged commit aae9c46 into plugin_api_v2 Dec 13, 2024
7 checks passed
@Garulf Garulf deleted the fix-infinite-updates-of-a-plugin branch December 13, 2024 17:22
@Garulf
Copy link
Member

Garulf commented Dec 13, 2024

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants