Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding http.Client argument to the MatomoDispatcher class #171

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

tfreebern2
Copy link
Contributor

httpClient is already an argument for the MatomoDispatcher class. This PR allows the developer to pass a custom http.Client through the initialize function.

@TesteurManiak
Copy link
Member

Why would this be needed? MatomoDispatcher is not even exposed by the library.

@tfreebern2
Copy link
Contributor Author

tfreebern2 commented Aug 27, 2024

Why would this be needed? MatomoDispatcher is not even exposed by the library.

The Matomo instance that my project is connected to requires certificate pinning. I've already created a fork that allows us to pass in a custom http.Client to pin the certificate required to hit the instance.

@TesteurManiak TesteurManiak merged commit 650180d into Floating-Dartists:main Aug 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants